feat: add getMappings method to QualifiedNameLookup#1228
Merged
Conversation
ava-fred
force-pushed
the
work.251117
branch
from
7e07eda to
bbfcc2f
Compare
rubenporras
requested changes
Nov 27, 2025
| } | ||
| } | ||
| if (ArrayUtils.find(values, value) >= 0) { | ||
| List<String> l = new ArrayList<>(); |
Member
There was a problem hiding this comment.
Suggested change
| List<String> l = new ArrayList<>(); | |
| List<String> l = new ArrayList<>(1); |
| } | ||
|
|
||
| List<List<String>> mappings = root.getMappings(value); | ||
| List<QualifiedName> result = new ArrayList<>(); |
Member
There was a problem hiding this comment.
Suggested change
| List<QualifiedName> result = new ArrayList<>(); | |
| List<QualifiedName> result = new ArrayList<>(mappings.size()); |
| if (children != null) { | ||
| for (SegmentNode node : children) { | ||
| List<List<String>> childResult = node.getMappings(value); | ||
| for (List<String> mapping : childResult) { |
Member
There was a problem hiding this comment.
Suggested change
| for (List<String> mapping : childResult) { | |
| for (List<String> mapping : node.getMappings(value)) { |
and remove the local variable?
As per title.
ava-fred
force-pushed
the
work.251117
branch
from
bbfcc2f to
1f59632
Compare
rubenporras
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title.